Fix tab management and random data generation#2631
Merged
labkey-tchad merged 4 commits intorelease25.7-SNAPSHOTfrom Aug 15, 2025
Merged
Fix tab management and random data generation#2631labkey-tchad merged 4 commits intorelease25.7-SNAPSHOTfrom
labkey-tchad merged 4 commits intorelease25.7-SNAPSHOTfrom
Conversation
Member
Author
labkey-danield
approved these changes
Aug 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
doAndWaitForWindowwas implemented incorrectly. It needs to switch to the named window before callingdoAndMaybeWaitForPageToLoadso that the page load is correctly detected.TestDataGenerator.getDefaultDataSupplierto generate random data for textChoice fields, I assumed that we weren't generating random data for other field types with aconceptURI. We are generating random values for someSamplecolumns so I've restored the old behavior for other column types.Related Pull Requests
Changes